mongo insert deprecated, updating #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkrzysiak
reviewed
Apr 27, 2020
|
|
||
| insertOne.prototype._fn = function(d) { | ||
| return this.collection | ||
| .then(collection =>collection.insertOne(d,this.options)) |
There was a problem hiding this comment.
Nice work on this PR! Would this work followed by an etl.collect(10)? I am getting doc has to be object error, which I assume means that due to a collect this is passing an array of docs. I think the docs in this PR should reflect this, remove the collect(10) in the example maybe?
|
Tests passing locally, can re-run the checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added insertOne, marked insert as deprecated.